refactor(QOV-1609): skip private subnet requirement when Karpenter is enabled without private nodes#2409
Open
gdubroeucq wants to merge 1 commit intostagingfrom
Open
refactor(QOV-1609): skip private subnet requirement when Karpenter is enabled without private nodes#2409gdubroeucq wants to merge 1 commit intostagingfrom
gdubroeucq wants to merge 1 commit intostagingfrom
Conversation
… enabled without private nodes
Member
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #2409 +/- ##
===========================================
+ Coverage 47.27% 53.84% +6.57%
===========================================
Files 1272 331 -941
Lines 23589 6808 -16781
Branches 6965 2128 -4837
===========================================
- Hits 11152 3666 -7486
+ Misses 10304 2411 -7893
+ Partials 2133 731 -1402
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rmnbrd
approved these changes
Feb 23, 2026
Contributor
Author
|
Ready for merge 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue:
For Jamloop, they have a cluster with an existing VPC and only public subnets. With the current flow, when we enable Karpenter it asks for private subnet but we dont need them (see last screenshot as we deploy in public subnet anyway)
Screenshots / Recordings
Before (when enabling Karpenter on existing VPC):

After (it doesn't ask for private subnet):

The logic is already done in the network settings (private node toggle to know if we deploy on private/public):

Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release