Skip to content

Comments

refactor(QOV-1609): skip private subnet requirement when Karpenter is enabled without private nodes#2409

Open
gdubroeucq wants to merge 1 commit intostagingfrom
karpenter-existing-vpc-fix
Open

refactor(QOV-1609): skip private subnet requirement when Karpenter is enabled without private nodes#2409
gdubroeucq wants to merge 1 commit intostagingfrom
karpenter-existing-vpc-fix

Conversation

@gdubroeucq
Copy link
Contributor

@gdubroeucq gdubroeucq commented Feb 23, 2026

Summary

Issue:

For Jamloop, they have a cluster with an existing VPC and only public subnets. With the current flow, when we enable Karpenter it asks for private subnet but we dont need them (see last screenshot as we deploy in public subnet anyway)

Screenshots / Recordings

Before (when enabling Karpenter on existing VPC):
image

After (it doesn't ask for private subnet):
image

The logic is already done in the network settings (private node toggle to know if we deploy on private/public):
image

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview e68a6997-01bc-4a01-adcd-e763ade8d2ae test-prod-clone-pipeline-clone-test
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview 964984c5-fba6-4371-88d3-a5daf99642ab test-prod
/qovery preview 939e824e-ace5-46db-852e-4db251209aeb test-prod-clone
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Don’t Sacrifice Readability, you are going to debug it in 6 months

@gdubroeucq gdubroeucq marked this pull request as draft February 23, 2026 11:42
@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.84%. Comparing base (9615113) to head (52d196f).

Files with missing lines Patch % Lines
...-resources-settings/cluster-resources-settings.tsx 12.50% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2409      +/-   ##
===========================================
+ Coverage    47.27%   53.84%   +6.57%     
===========================================
  Files         1272      331     -941     
  Lines        23589     6808   -16781     
  Branches      6965     2128    -4837     
===========================================
- Hits         11152     3666    -7486     
+ Misses       10304     2411    -7893     
+ Partials      2133      731    -1402     
Flag Coverage Δ
unittests 53.84% <12.50%> (+6.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gdubroeucq gdubroeucq marked this pull request as ready for review February 23, 2026 13:47
@gdubroeucq gdubroeucq marked this pull request as draft February 23, 2026 13:55
@gdubroeucq gdubroeucq marked this pull request as ready for review February 23, 2026 14:04
@rmnbrd rmnbrd changed the title refactor(QOV-1609): skip private subnet requirement when Karpenter is… refactor(QOV-1609): skip private subnet requirement when Karpenter is enabled without private nodes Feb 23, 2026
@gdubroeucq
Copy link
Contributor Author

Ready for merge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants